New joomla user search API #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojLondhe
reviewed
Nov 5, 2017
| @@ -0,0 +1,46 @@ | |||
| <?php | |||
There was a problem hiding this comment.
@coolbung should resource name be search?
There was a problem hiding this comment.
I think search API is nothing but the list view with the additional filters. Can we merge this code with users post API? cc @coolbung
There was a problem hiding this comment.
Yes. Please go ahead as discussed.
Once merged, moved out the plugins in the respective repos. Any plugin that does not have a specific repo can stay here.
manojLondhe
reviewed
Nov 5, 2017
users/users/user.php
Outdated
| @@ -0,0 +1,46 @@ | |||
| <?php | |||
| /** | |||
| * @package Joomla.Administrator | |||
There was a problem hiding this comment.
@samadhansalunkhe change copyright, year etc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced Issue - https://github.com/ekstep/Community-Portal-Joomla/issues/5197