90% - Made validate token call callback with err on invalid token

[scaleupcto]

The existing validateToken method had unreachable code for case INVALID_TOKEN, instead it was throwing the uncaught error from validateOps. The express middleware wrapper caught this behaviour and called its callback with the correct error.

Instead just have validateToken do that in the first place.

[rsinger]

Would it be worth adding a simple unit test to token_validation_tests to make sure we don't ever undo your good work here?

[scaleupcto]

There is an existing test case on the validateHTTP, which should still pass, but guess no harm to do validateToken directly too

[scaleupcto]

Actually, there wasn't one for no token, just an existing invalid token. Have added one that covers both scenarios (as one method depends on the other).

[rsinger]

👍