YEL-42 [feat] 소셜 로그인 API 및 Authorization 구현 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euije
approved these changes
Jul 12, 2023
Comment on lines
+40
to
+47
| @ExceptionHandler({ | ||
| CustomAuthenticationException.class, | ||
| ExpiredTokenException.class, | ||
| InvalidTokenException.class, | ||
| NotSignedInException.class, | ||
| OAuthException.class | ||
| }) | ||
| public ResponseEntity<BaseResponse> UnauthorizedException(CustomException exception) { |
There was a problem hiding this comment.
엇 근데 이거 exception 수정된거로 바꿔야하는거 아닌가요?
Comment on lines
+45
to
+48
| .addFilterBefore(new ExceptionHandlerFilter(), UsernamePasswordAuthenticationFilter.class) | ||
| .addFilterBefore(new JwtFilter(new JwtTokenProvider(), secretKey), | ||
| UsernamePasswordAuthenticationFilter.class) | ||
| .addFilterBefore(new JwtExceptionFilter(), JwtFilter.class) |
There was a problem hiding this comment.
이렇게 되면 코드 순서대로 filter가 순서를 이루게 되나요?
Comment on lines
+36
to
+39
| if (requestPath.startsWith("/api/v1/auth/oauth")) { | ||
| filterChain.doFilter(request, response); | ||
| return; | ||
| } |
hyeonjeongs
approved these changes
Jul 12, 2023
Comment on lines
+22
to
+24
| private static final Long accessTokenValidTime = ofHours(4).toMillis(); | ||
| private static final Long refreshTokenValidTime = ofDays(14).toMillis(); | ||
|
|
There was a problem hiding this comment.
숫자는 static으로 선언한거 갖고오는게 어떤가요?
Comment on lines
+40
to
+47
| @ExceptionHandler({ | ||
| CustomAuthenticationException.class, | ||
| ExpiredTokenException.class, | ||
| InvalidTokenException.class, | ||
| NotSignedInException.class, | ||
| OAuthException.class | ||
| }) | ||
| public ResponseEntity<BaseResponse> UnauthorizedException(CustomException exception) { |
Comment on lines
+40
to
+47
| @ExceptionHandler({ | ||
| CustomAuthenticationException.class, | ||
| ExpiredTokenException.class, | ||
| InvalidTokenException.class, | ||
| NotSignedInException.class, | ||
| OAuthException.class | ||
| }) | ||
| public ResponseEntity<BaseResponse> UnauthorizedException(CustomException exception) { |
There was a problem hiding this comment.
엇 근데 이거 exception 수정된거로 바꿔야하는거 아닌가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☘️ Related Issue
✅ Work description
💡 PR point