Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YEL-34 [feat] YELL:O 투표 리스트 조회 #31

Merged
merged 4 commits into from
Jul 12, 2023
Merged

YEL-34 [feat] YELL:O 투표 리스트 조회 #31

merged 4 commits into from
Jul 12, 2023

Conversation

hyeonjeongs
Copy link
Member

☘️ Related Issue

  • resolves YEL-34

✅ Work description

  • 투표 리스트 조회

💡 PR point

  • 더 효율적인 코드가 있다면 조언 부탁드립니다!

@hyeonjeongs hyeonjeongs added feat 새로운 기능 구현 현정👕 labels Jul 10, 2023
@hyeonjeongs hyeonjeongs self-assigned this Jul 10, 2023
euije
euije approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@euije euije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳

devkwonsehoon
devkwonsehoon reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@devkwonsehoon devkwonsehoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 PR에 올린 거 체크해주심 될 것 같슴다

src/main/java/com/yello/server/domain/question/controller/YelloVoteController.java
Comment on lines +26 to +28
@RequestMapping("api/v1/yello")
@RequiredArgsConstructor
public class YelloVoteController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 PR에서도 언급했지마는
네이밍 + 매핑 URL 고민

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 알겠습니다!!

@hyeonjeongs hyeonjeongs merged commit 1f0b8cd into develop Jul 12, 2023
1 check passed
@euije euije deleted the feat/YEL-34-get-vote branch July 12, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkwonsehoon devkwonsehoon devkwonsehoon left review comments

@euije euije euije approved these changes

Assignees

@hyeonjeongs hyeonjeongs

Labels
feat 새로운 기능 구현 현정👕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyeonjeongs @euije @devkwonsehoon