YEL-40 [fix] 코드리뷰 반영

team-yello · Jul 12, 2023 · 8465745 · 8465745
1 parent ddcd352
commit 8465745
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 38 deletions.
diff --git a/src/main/java/com/yello/server/domain/question/dto/response/YelloFriend.java b/src/main/java/com/yello/server/domain/question/dto/response/YelloFriend.java
@@ -1,9 +1,9 @@
 package com.yello.server.domain.question.dto.response;
 
 import com.yello.server.domain.friend.entity.Friend;
-import com.yello.server.domain.user.entity.User;
 import lombok.Builder;
 
+@Builder
 public record YelloFriend(
  Long id,
  String yelloId,
@@ -17,10 +17,4 @@ public static YelloFriend of(Friend friend) {
  .build();
  }
 
- @Builder
- public YelloFriend(Long id, String yelloId, String name) {
- this.id = id;
- this.yelloId = yelloId;
- this.name = name;
- }
 }
diff --git a/src/main/java/com/yello/server/domain/question/dto/response/YelloKeyword.java b/src/main/java/com/yello/server/domain/question/dto/response/YelloKeyword.java
@@ -3,17 +3,14 @@
 import com.yello.server.domain.keyword.entity.Keyword;
 import lombok.Builder;
 
+@Builder
 public record YelloKeyword(
  String keywordName
 ) {
- public static YelloKeyword of(Keyword keyword){
+ public static YelloKeyword of(Keyword keyword) {
  return YelloKeyword.builder()
  .keywordName(keyword.getKeywordName())
  .build();
  }
 
- @Builder
- public YelloKeyword(String keywordName) {
- this.keywordName = keywordName;
- }
 }
diff --git a/src/main/java/com/yello/server/domain/question/dto/response/YelloQuestion.java b/src/main/java/com/yello/server/domain/question/dto/response/YelloQuestion.java
@@ -4,15 +4,15 @@
 import lombok.Builder;
 
 import java.util.Objects;
-import java.util.Optional;
 
+@Builder
 public record YelloQuestion(
  String nameHead,
  String nameFoot,
  String keywordHead,
  String keywordFoot
 ) {
- public static YelloQuestion of(Question question){
+ public static YelloQuestion of(Question question) {
  return YelloQuestion.builder()
  .nameHead(Objects.isNull(question.getNameHead()) ? null : question.getNameHead())
  .nameFoot(Objects.isNull(question.getNameFoot()) ? null : question.getNameFoot())
@@ -21,11 +21,5 @@ public static YelloQuestion of(Question question){
  .build();
  }
 
- @Builder
- public YelloQuestion(String nameHead, String nameFoot, String keywordHead, String keywordFoot) {
- this.nameHead = nameHead;
- this.nameFoot = nameFoot;
- this.keywordHead = keywordHead;
- this.keywordFoot = keywordFoot;
- }
+
 }
diff --git a/src/main/java/com/yello/server/domain/question/dto/response/YelloStartResponse.java b/src/main/java/com/yello/server/domain/question/dto/response/YelloStartResponse.java
@@ -1,19 +1,12 @@
 package com.yello.server.domain.question.dto.response;
 
-import com.yello.server.domain.cooldown.entity.Cooldown;
-import com.yello.server.domain.user.entity.User;
 import lombok.Builder;
 
+@Builder
 public record YelloStartResponse(
  Boolean isStart,
  Integer point,
  String createdAt
-){
+) {
 
- @Builder
- public YelloStartResponse(Boolean isStart, Integer point, String createdAt) {
- this.isStart = isStart;
- this.point = point;
- this.createdAt = createdAt;
- }
 }
diff --git a/src/main/java/com/yello/server/domain/question/dto/response/YelloVoteResponse.java b/src/main/java/com/yello/server/domain/question/dto/response/YelloVoteResponse.java
@@ -4,18 +4,12 @@
 
 import java.util.List;
 
+@Builder
 public record YelloVoteResponse(
  YelloQuestion question,
  List<YelloFriend> friendList,
  List<YelloKeyword> keywordList,
  Integer questionPoint
 ) {
-
- @Builder
- public YelloVoteResponse(YelloQuestion question, List<YelloFriend> friendList, List<YelloKeyword> keywordList, Integer questionPoint) {
- this.question = question;
- this.friendList = friendList;
- this.keywordList = keywordList;
- this.questionPoint = questionPoint;
- }
+
 }