Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DurationFormat: Add tests for durations with large hour/minute/second unit values while using digital style #4268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DurationFormat: Add tests for durations with large hour/minute/second unit values while using digital style #4268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test/intl402/DurationFormat/prototype/format/style-digital-large-hms-values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
// Copyright (C) 2024 Igalia, S.L. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-formatnumericunits
description: >
Test to ensure that grouping separators are suppressed when formatting Durations with /hour, minute, and second values while using digital style.

info: |
1.1.12 FormatNumericUnits ( durationFormat, duration, firstNumericUnit, signDisplayed )

16. If hoursFormatted is true, then
...
b. Append FormatNumericHours ( durationFormat, hoursValue, signDisplayed ) to numericPartsList.
17. If minutesFormatted is true, then
...
b. Append FormatNumericMinutes ( durationFormat, minutesValue, hoursFormatted, signDisplayed ) to numericPartsList.
18. If secondsFormatted is true, then
a. Append FormatNumericSeconds ( durationFormat, secondsValue, minutesFormatted, signDisplayed ) to numericPartsList.

1.1.9 FormatNumericHours ( durationFormat, hoursValue, signDisplayed )
...
9. Perform ! CreateDataPropertyOrThrow(nfOpts, "useGrouping", false).

1.1.10 FormatNumericMinutes (durationFormat, minutesValue, hoursDisplayed, signDisplayed)
...
10. Perform ! CreateDataPropertyOrThrow(nfOpts, "useGrouping", false).

1.1.11 FormatNumericSeconds ( durationFormat, secondsValue, minutesDisplayed, signDisplayed )
...
10. Perform ! CreateDataPropertyOrThrow(nfOpts, "useGrouping", false).

locale: [en]
features: [Intl.DurationFormat]
---*/

const locale = "en";
const duration = {hours: 1234, minutes: 1234567, seconds: 12345678};

let df = new Intl.DurationFormat(locale, {style: "digital"});

assert.sameValue(df.format(duration), "1234:1234567:12345678", `failed to suppress grouping separator using digital style`);
Loading