Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML Hub - resolve base path implicitly #403

Merged
merged 3 commits into from
Jul 16, 2024
Merged

ML Hub - resolve base path implicitly #403

merged 3 commits into from
Jul 16, 2024

Conversation

dhannywi
Copy link
Collaborator

Overview:

  • changed implementation from a hard-coded basePath to resolving basePath implicitly

Related Github Issues:

Summary of Changes:

Testing Steps:

  1. @dhannywi will test locally if the new implementation works as expected once @NotChristianGarcia register ML Hub's Hub pod on NGINX proxy

UI Photos:

Notes:

@dhannywi dhannywi self-assigned this Jul 16, 2024
@NotChristianGarcia NotChristianGarcia merged commit 50644de into dev Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotChristianGarcia NotChristianGarcia Awaiting requested review from NotChristianGarcia

Assignees

@dhannywi dhannywi

Labels
None yet
Projects
Tapis Project Beta Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhannywi @NotChristianGarcia