MP-ECDSA #37
Merged
MP-ECDSA #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
requested changes
Nov 29, 2023
drewstone
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Some scaffold looks OK, but generally doesn't seem like the approach you've taken is correct given the new architecture. There is no base DKG anymore and it does not rotate on sessions. The client API from dkg-substrate is not being included in Tangle mainnet at all. There will be no best authorities, next best authorities, signature thresholds, etc. Everything should be tied to a job. After receiving job details we should execute keygen or signing protocols. CC @1xstj
shekohex
reviewed
Dec 8, 2023
shekohex
reviewed
Dec 8, 2023
added 6 commits
December 8, 2023 09:53
…etween keygen and signing), begin adding public key gossip phase
drewstone
reviewed
Dec 12, 2023
|
Looks good. @tbraun96 lets rename webb-gadget to gadget-common and move the client.rs implementation there. Which will be reusable between all gadgets. |
Rename webb-gadget to gadget-common Make keystore more generalized
shekohex
requested changes
Dec 13, 2023
added 2 commits
December 13, 2023 10:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26