Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Fix liquid staking pools bugs #2622

Merged
merged 14 commits into from
Nov 2, 2024

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Oct 29, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • Fixed LS bugs listed below.
  • Fixed outdated link to token allocation docs page.
  • Cleaned up explorer URL logic & hooks.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.


Optional Checklist

  • I have tested the changes locally.
  • I have added brief documentation/comments to more complex code blocks or logic that isn't immediately clear.
  • If new components were added, I've also added and verified their different possible states & edge cases (e.g. loading, error, empty).
  • For UI changes, I've tested the changes on different screen sizes (responsive design).
  • For UI changes, I've checked both light and dark mode.
  • I've checked the console for any errors that might have been accidentally introduced by my changes.
  • If important TODOs were left, I've created corresponding issues for them.
  • If new flows or features were introduced, I've updated, added, or intend to add corresponding documentation including screenshots and/or screen recordings for them on the Webb Docs repository.

@yurixander yurixander self-assigned this Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 85a754b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/672636af392edd0008362534
😎 Deploy Preview https://deploy-preview-2622--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 85a754b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/672636afa777d100081e22dc
😎 Deploy Preview https://deploy-preview-2622--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander yurixander marked this pull request as ready for review November 2, 2024 15:47
@drewstone drewstone merged commit 8ffbd7d into develop Nov 2, 2024
15 checks passed
@drewstone drewstone deleted the yuri/fix-ls-pools-bugs branch November 2, 2024 17:48
@drewstone
Copy link
Contributor

Nice let's cut new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants