Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 ChainButton, WalletButton and LoadingPill #1489

Merged
merged 22 commits into from
Aug 1, 2023
Merged

V2 ChainButton, WalletButton and LoadingPill #1489

merged 22 commits into from
Aug 1, 2023

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Aug 1, 2023 •
edited
Loading

Summary of changes

  • Add and integrate a new Chain button component.
  • Add and integrate a new Wallet button component.
  • Add a new LoadingPill button component.
  • Fix the theme issue between the Bridge DApp and Storybook.

Proposed area of change

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/webbsite
  • apps/faucet
  • apps/tangle-website
  • libs/webb-ui-components

Reference issue to close (if applicable)

Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

AtelyPham and others added 21 commits July 28, 2023 00:19
@AtelyPham
feat: add StatusIndicator component to webb-ui-kit
cc6269b
@AtelyPham
Merge remote-tracking branch 'origin/hubble-bridge-v2' into trung-tin…
319cedd 
…/status-indicator
@AtelyPham
fix: move StatusIndicator to svg to fix the width issue
81b3f99
@AtelyPham
chore: add Storybook for StatusIndicator
50fa1ef
@AtelyPham
chore: rename Button to buttons for namespace purpose
292e7ad
@AtelyPham
chore: export default for Button*
fcbda55
@AtelyPham
feat: add v2 ChainButton component
01a88dd
@AtelyPham
Merge remote-tracking branch 'origin/trung-tin/status-indicator' into…
5d916c5 
… trung-tin/v2-chain-wallet-buttons
@AtelyPham
chore: move StatusIndicator into icons lib to use with ChainIcon
9562c31
@AtelyPham
feat: add status for ChainButton
79cc5ff
@AtelyPham
Merge branch 'hubble-bridge-v2' into trung-tin/v2-chain-wallet-buttons
378305e
@AtelyPham
feat: add WalletButton component
5e70f9b
@AtelyPham
Merge remote-tracking branch 'origin/develop' into trung-tin/v2-chain…
39bcbba 
…-wallet-buttons
@AtelyPham
Merge branch 'hubble-bridge-v2' into trung-tin/v2-chain-wallet-buttons
74d9540
@devpavan04
Hubble Stats Breadcrumbs (#1470)
15ca596
@AtelyPham
Fix Token Approval Issue (#1480)
06bd9d6
@AtelyPham @drewstone
Add More Rpc Urls to Support Multiple Providers (#1471)
27dcf65 
Co-authored-by: drewstone <[email protected]>
@AtelyPham
Merge branch 'develop' into trung-tin/v2-chain-wallet-buttons
45498f0
@AtelyPham
chore: integrate new chain button into the bridge
d089c42
@AtelyPham
fix: the theme issue
0103685
@AtelyPham
chore: integrate new wallet button into the bridge
a222f26
@AtelyPham AtelyPham added the needs review 👓 Pull request needs a review label Aug 1, 2023
@AtelyPham AtelyPham self-assigned this Aug 1, 2023
This was linked to issues Aug 1, 2023
[TASK] Update Chain Connection component #1411
Closed
[TASK] Update Wallet Address component & add to UI Kit #1414
Closed
@AtelyPham AtelyPham changed the title V2 Chain & Wallet Buttons V2 ChainButton, WalletButton and LoadingPill Aug 1, 2023
@AtelyPham AtelyPham linked an issue Aug 1, 2023 that may be closed by this pull request
[TASK] Implement Loading Pillcomponent for tx status #1456
Closed
drewstone
drewstone approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@AtelyPham AtelyPham merged commit 328bb03 into hubble-bridge-v2 Aug 1, 2023
6 checks passed
@AtelyPham AtelyPham deleted the trung-tin/v2-chain-wallet-buttons branch August 1, 2023 20:28
This was referenced Aug 2, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewstone drewstone drewstone approved these changes

@devpavan04 devpavan04 Awaiting requested review from devpavan04

@vutuanlinh2k2 vutuanlinh2k2 Awaiting requested review from vutuanlinh2k2

Assignees

@AtelyPham AtelyPham

Labels
needs review 👓 Pull request needs a review
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
3 participants
@AtelyPham @drewstone @devpavan04