Update ./routes/utils.ts functions to use object for O(1) lookups #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or file lookups reducing time complexity from O(n) to O(1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problem with the browser causing a hang on ComfyUI launch due to my large number of files. I traced the problem to the processFile function which is searching for json files relying on the findFile function which is naively looping over the entire list of images causing the number of iterations to grow at a rate of O(n^2). This can be fixed by changing the return value of fetchFiles to a map allowing O(1) lookup times. I've updated the necessary functions to enable this change/fix this issue.
Resolves issue #49
Resubmitting with clean commit history