Skip to content

Commit

Permalink
Updated composer dependencies, updated docs, added Qodana code qualit…
Browse files Browse the repository at this point in the history
…y tool integration.
  • Loading branch information
DKravtsov committed Oct 1, 2023
1 parent f2137a5 commit 0a884b6
Show file tree
Hide file tree
Showing 27 changed files with 1,267 additions and 1,341 deletions.
5 changes: 5 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ jobs:
make wait-for-elastic
make elastic-create-or-update-template
- run:
name: Show framework version and additional info, php & composer version
command: |
make info
- run:
name: Run unit/functional tests
command: |
Expand Down
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ XDEBUG_CONFIG=main
MYSQL_VERSION=8.1
# MySQL INNODB_USE_NATIVE_AIO possible values: 1|0. Set to 0 when AIO interface is not supported on OSX. https://dev.mysql.com/doc/refman/8.0/en/innodb-parameters.html#sysvar_innodb_use_native_aio
INNODB_USE_NATIVE_AIO=1
# Sometimes AWS MySQL RDS has SQL_MODE="NO_ENGINE_SUBSTITUTION" (https://github.com/awsdocs/amazon-rds-user-guide/issues/160 ) but MySQL default described here - https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_sql_mode
# Sometimes AWS MySQL RDS has SQL_MODE="NO_ENGINE_SUBSTITUTION" (https://github.com/awsdocs/amazon-rds-user-guide/issues/160) but MySQL default described here - https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_sql_mode
SQL_MODE="ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION"
###< docker configuration that can be overridden in .env.local ###

Expand Down
22 changes: 19 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@ on:
types: [published]

jobs:

build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- name: Set Elastic data folder rights
Expand All @@ -44,6 +41,8 @@ jobs:
run: make wait-for-elastic
- name: Create or update Elastic index template
run: make elastic-create-or-update-template
- name: Show framework version and additional info, php & composer version
run: make info
- name: Run test suite
run: make phpunit
- name: Run coding standard
Expand All @@ -60,3 +59,20 @@ jobs:
run: make phpmd
- name: Stop the docker images
run: make stop-test

qodana:
runs-on: ubuntu-latest
needs: build
permissions:
contents: write
pull-requests: write
checks: write
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }} # to check out the actual pull request commit, not the merge commit
fetch-depth: 0 # a full history is required for pull request analysis
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
env:
QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }}
63 changes: 32 additions & 31 deletions Makefile

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"Elasticsearch"
],
"homepage": "https://github.com/systemsdk/docker-symfony-api",
"version": "v1.6.0",
"version": "v1.6.1",
"license": "MIT",
"authors": [
{
Expand Down Expand Up @@ -100,7 +100,7 @@
"roave/security-advisories": "dev-latest",
"symfony/browser-kit": "6.3.*",
"symfony/debug-bundle": "6.3.*",
"symfony/maker-bundle": "^1.50",
"symfony/maker-bundle": "^1.51",
"symfony/requirements-checker": "^2.0",
"symfony/stopwatch": "6.3.*",
"symfony/var-dumper": "6.3.*",
Expand Down
Loading

0 comments on commit 0a884b6

Please sign in to comment.