Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package manager #1137

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Update package manager #1137

merged 8 commits into from
Sep 12, 2023

Conversation

ahoneybun
Copy link
Member

Address issue: #939

@ahoneybun ahoneybun requested review from thomas-zimmerman and a team May 24, 2023 17:55
thomas-zimmerman
thomas-zimmerman reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to be explicit on what files are helpful

thomas-zimmerman
thomas-zimmerman requested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoneybun Thoughts on the updated wording?

@n3m0-22 n3m0-22 self-assigned this May 24, 2023
n3m0-22
n3m0-22 suggested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands work as expected, but I'm not sure about the capitalization of Apt/Dpkg. I would recommend it be swapped with APT/dpkg based on the Wikipedia pages.

@jacobgkau
Copy link
Member

jacobgkau commented May 24, 2023 •
edited
Loading

For what it's worth, we used Apt at the beginning of sentences or titles a couple of times in the unfinished Pop!_Docs: https://github.com/pop-os/docs/blob/main/src/manage-apps/fix-packages.md, https://github.com/pop-os/docs/blob/main/src/manage-apps/using-terminal.md

Although it is technically APT according to upstream (or apt when referring to the command): https://salsa.debian.org/apt-team/apt

Debian does refer to Dpkg with that capitalization e.g. in the names of its development teams (as well as config flags), although they also use all-lowercase sometimes: https://wiki.debian.org/Teams/Dpkg, https://salsa.debian.org/dpkg-team

@thomas-zimmerman
Copy link
Contributor

Updated article to address APT discussion. Please squish changes if merging.

@jacobgkau
Copy link
Member

Why'd you change Pop!_Shop to Pop Shop in the Pop article?

@ahoneybun
Copy link
Member Author

Why'd you change Pop!_Shop to Pop Shop in the Pop article?

Should be fixed now.

@ahoneybun ahoneybun requested a review from n3m0-22 May 25, 2023 17:42
n3m0-22
n3m0-22 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ahoneybun ahoneybun requested a review from a team August 3, 2023 19:40
Aaron Honeycutt and others added 6 commits August 3, 2023 15:17
@jacobgkau jacobgkau requested a review from a team August 3, 2023 22:35
thomas-zimmerman
thomas-zimmerman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get these pending changes out. It looks like the APT/Dpkg concernss are addressed

@ahoneybun ahoneybun merged commit 7800619 into master Sep 12, 2023
3 checks passed
@ahoneybun ahoneybun deleted the update-package-manager branch September 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobgkau jacobgkau jacobgkau approved these changes

@n3m0-22 n3m0-22 n3m0-22 approved these changes

@thomas-zimmerman thomas-zimmerman thomas-zimmerman approved these changes

Assignees

@n3m0-22 n3m0-22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoneybun @jacobgkau @thomas-zimmerman @n3m0-22