Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate PDF/HTML on release event with GitHub Actions #15

Closed
wants to merge 1 commit into from

Conversation

et84121
Copy link

@et84121 et84121 commented Jul 28, 2021

this feature will trigger github action to generating book on github released event and the book will be uploaded to release assets

Github Page Setting

repo owner should set repo setting like this pic
image

@jserv
Copy link
Contributor

jserv commented Jul 28, 2021

Thanks for the patch! I really appreciate that. However, I could not recognize the source code listing (with indention and syntax highlighting) in generated HTML with pandoc. Did you suffer from the same problem?

@jserv jserv changed the title feat: add auto generating book on release by github action feat: Generate PDF/HTML on demand with GitHub Actions Jul 28, 2021
@jserv jserv changed the title feat: Generate PDF/HTML on demand with GitHub Actions feat: Generate PDF/HTML on release event with GitHub Actions Jul 28, 2021
@jserv
Copy link
Contributor

jserv commented Jul 28, 2021

I could not recognize the source code listing (with indention and syntax highlighting) in generated HTML with pandoc.

The corresponding GitHub Pages I am addressing: https://jserv.github.io/lkmpg/
Check the section "Examples" and no real LKM source code was shown.

@jserv
Copy link
Contributor

jserv commented Jul 28, 2021

The generated PDF was malformed as well. See https://jserv.github.io/lkmpg/lkmpg.pdf

@et84121
Copy link
Author

et84121 commented Jul 28, 2021

I only use the default setting to generate files.
Maybe pandoc needs more parameters.
I'll check it out.

@et84121
Copy link
Author

et84121 commented Jul 28, 2021

After investigation, that's because pandoc can't handle latex's external dependencies.
Perhaps another solution is embedding PDF file generated by pdflatex on the website

That's a harmless info message. Pandoc will only try to parse xcolor.sty if it's in the working directory (or --resource-path). That's usually what you want; pandoc usually can't handle the low-level tex in these sty files.
Originally posted by @jgm in jgm/pandoc#5730 (comment)

@et84121
Copy link
Author

et84121 commented Jul 28, 2021

I also tried to use other tools to generate HTML files, and this tool can successfully handle external dependencies, but it did not work for the "Undefined control sequence" reasons.

@jserv
Copy link
Contributor

jserv commented Jul 30, 2021

I also tried to use other tools to generate HTML files, and this tool can successfully handle external dependencies, but it did not work for the "Undefined control sequence" reasons.

Let's consolidate #20 before working on GitHub Actions/Pages.

@jserv
Copy link
Contributor

jserv commented Aug 2, 2021

Close in favor of #32

@jserv jserv closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants