Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend full description for all file access #2096

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Aug 10, 2024

Apparently the core use-cases for which google play allows the use of the all file access permission needs to be prominently mentioned. It's thus not an entirely organic description, I quite closely followed those and tried to incorporate some words directly. While still keeping it (hopefully) quite readable and potentially useful to real users (while the main target is dumb compliance).
https://support.google.com/googleplay/android-developer/answer/10467955?visit_id=638568800696248236-2021199491&rd=1#zippy=%2Cpermitted-uses-of-the-all-files-access-permission

Also I realised we never update play information. I did it manually for now. If play gets unstuck, I'll add a a github actions pipeline to do google play description updates. Right now I don't feel like spending that time given the uncertain future of google play.

Syncthing replaces proprietary sync and cloud services with something open, trustworthy and decentralized. Your data is your data alone and you deserve to choose where it is stored, if it is shared with some third party and how it's transmitted over the Internet.
Syncthing replaces proprietary sync and cloud services with something open, trustworthy and decentralized. Your data is your data alone and you deserve to choose where it is stored, if it is shared with some third party and how it's transmitted over the internet.

You can select any directory, including the user data directory itself to let syncthing sync the files there (subject to restrictions by android and your device's vendor) - that's why this app requests the permission to access all files. This allows you to keep all the data you need and create on your phone in sync with another of your devices (computer, another phone, ...). This can serve many use-cases, it's all up to you. Typically it can be used to manage files from that other device (e.g. restructure or delete files), as a step (!) to back up your (app) data (you need a dedicated backup program to actually secure your data on a synced device) or to help with migrating to a new device (just setup syncthing-android there as well, and your data gets synced to that new device).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can select any directory, including the user data directory itself to let syncthing sync the files there (subject to restrictions by android and your device's vendor) - that's why this app requests the permission to access all files. This allows you to keep all the data you need and create on your phone in sync with another of your devices (computer, another phone, ...). This can serve many use-cases, it's all up to you. Typically it can be used to manage files from that other device (e.g. restructure or delete files), as a step (!) to back up your (app) data (you need a dedicated backup program to actually secure your data on a synced device) or to help with migrating to a new device (just setup syncthing-android there as well, and your data gets synced to that new device).
You can select any directory, including the user data directory itself to let Syncthing sync the files there (subject to restrictions by Android and your device's vendor) - that's why this app requests the permission to access all files. This allows you to keep all the data you need and create on your phone in sync with another of your devices (computer, another phone, etc.). This can serve many use cases, it's all up to you. Typically it can be used to manage files from that other device (e.g. restructure or delete files), as a step (!) to back up your (app) data (you need a dedicated backup program to actually secure your data on a synced device) or to help with migrating to a new device (just set up syncthing-android there as well, and your data gets synced to that new device).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, addressed. And added hard wrapping to make diffs a bit less terrible (confirmed that it won't have any influence on the rendition in google play).

Copy link
Contributor

@tomasz1986 tomasz1986 Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem 😀.

(confirmed that it won't have any influence on the rendition in google play).

What about translations? I think the hard wrapping may cause problems there, as people may think that they need to keep their translations wrapped the same way as the English text… From what I see on Weblate, this whole description is treated as a single block to translate, with all the manually added new lines and such.

Maybe wrap it sentence by sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, didn't think about translations - I'll revert the hard-wrapping.

Apparently the core use-cases for which google play allows the use of
the all file access permission needs to be prominently mentioned. It's
thus not an entirely organic description, I quite closely followed those
and tried to incorporate some words directly. While still keeping
it (hopefully) quite readable and potentially useful to real
users (while the main target is dumb compliance).
https://support.google.com/googleplay/android-developer/answer/10467955?visit_id=638568800696248236-2021199491&rd=1#zippy=%2Cpermitted-uses-of-the-all-files-access-permission
@imsodin imsodin merged commit 17de6ee into syncthing:main Aug 11, 2024
1 check passed
@imsodin imsodin deleted the descr-full-file-access branch August 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants