-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cascade annotation option support in ClassSourceManipulator #1323
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few extra changes in here, but the meat of this looks good
}, | ||
"require-dev": { | ||
"composer/semver": "^3.0", | ||
"dbrekelmans/bdi": "dev-main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of these changes necessary?
@@ -11,7 +11,7 @@ | |||
> | |||
<php> | |||
<ini name="error_reporting" value="-1" /> | |||
<env name="TEST_DATABASE_DSN" value="mysql://root:root@127.0.0.1:3306/test_maker?serverVersion=5.7" /> | |||
<env name="TEST_DATABASE_DSN" value="mysql://root:root@mariadb:3306/test_maker?serverVersion=5.7" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this :)
7c4fcef
to
aacb253
Compare
isNullable: true, | ||
cascade: ['persist'], | ||
), | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the many_to_many and one_to_one test cases. It's enough to make sure that a "singular" and "collection" relationship are tested.
Allow adding the cascade annotation option for OneToMany, ManyToOne and ManyToMany relation in ClassSourceManipulator.
The OneToOne remains forced to ['persist', 'remove']
Related issue : #1316