fix(core): prevent GitHub API validation error by not sending empty a…

…nnotation arrays

src/core/github/commit-status-sender.ts

@@ -53,7 +53,7 @@ class CommitStatusSender {
 	}
 
 	private convertToCheckAnnotations(annotations: Swingletree.Annotation[]): ChecksCreateParamsOutputAnnotations[] {
-		return annotations.filter(i => i instanceof Swingletree.FileAnnotation)
+		const converted = annotations.filter(i => i instanceof Swingletree.FileAnnotation)
 			.map(annotation => {
 				const item = annotation as Swingletree.FileAnnotation;
 				return {
@@ -65,8 +65,14 @@ class CommitStatusSender {
 					annotation_level: this.convertSwingletreeSeverity(item.severity)
 				} as ChecksCreateParamsOutputAnnotations;
 			});
+
+		if (converted.length == 0) {
+			return undefined;
 		}
 
+		return converted;
+	}
+
 	public async sendAnalysisStatus(event: NotificationEvent) {
 
 		if (!(event.payload.source instanceof Swingletree.GithubSource)) {

test/core/commit-status-sender.spec.ts

@@ -72,7 +72,8 @@ describe("Commit Status Sender", () => {
 			markdown: "123",
 			sender: "testSender",
 			source: source,
-			title: "test title"
+			title: "test title",
+			annotations: []
 		});
 	});
 
@@ -92,4 +93,12 @@ describe("Commit Status Sender", () => {
 		sinon.assert.calledOnce(githubClientMock.createCheckStatus);
 	});
 
+	it("should not set an empty annotation array in the CheckRun request", async () => {
+		githubClientMock.createCheckStatus.resolves();
+
+		const result = await uut.sendAnalysisStatus(mockEvent);
+
+		expect(result.output.annotations).to.be.undefined;
+	});
+
 });