Replace expensive seat_get_config() functions with pointer #8269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor to Sway here. After studying Sway's codebase for a bit, due to wanting to implement something unrelated, I noticed that the function
seat_get_config()
(and it's sister functionseat_get_config_by_name()
) are both needlessly expensive and ultimately unneeded.Currently, Sway finds the config related to a seat by looping through all the seats and strcmp'ing their names until a match is found. This is obviously not very efficient.
My change simply replaces these functions with a pointer in
struct sway_seat
.Again, first time contributor, so I'm not super familiar with Sway's codebase, but I have tested the following with my patch:
*
) seat configurationSo far, no crashes or unexpected behaviour; but I do believe more rigorous testing is needed. I am daily driving this patch.