Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a progress bar vignette #2190

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Add a progress bar vignette #2190

merged 2 commits into from
Oct 20, 2024

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Oct 20, 2024

  • add a scenario showing an in-world progress bar

The motivation is that I eventually plan to use a similar system to report progress of tests.

Recording
progress

* add a scenario showing a in-world progress bar
@xsebek xsebek requested review from kostmo and byorgey October 20, 2024 14:35
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! It makes me wonder whether it would be worth adding a built-in, more streamlined way to include text entities, in cases like this when you want to label things on a world map.

@xsebek
Copy link
Member Author

xsebek commented Oct 20, 2024

Yeah, something like this would be nice:

palette:
  - char: 'X'  # {name: "X", display: {char: "X"}, description: ["X"], properties: [known]}

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Oct 20, 2024
@mergify mergify bot merged commit 0262f66 into main Oct 20, 2024
11 checks passed
@mergify mergify bot deleted the task/xsebek/progress-bar branch October 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants