Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print readable unicode characters #2041

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Pretty print readable unicode characters #2041

merged 2 commits into from
Jul 15, 2024

Conversation

nitinprakash96
Copy link
Collaborator

Closes #1943

Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a unit test or two to ensure this works as expected?

swarm.cabal Outdated
@@ -191,6 +191,7 @@ library swarm-lang
terminal-size >=0.3 && <1.0,
text,
text-rope >=0.2 && <0.3,
unicode-show,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the only place we have this listed, let's include bounds, like unicode-show >= 0.1 && <0.2.

Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitinprakash96 nitinprakash96 added the merge me Trigger the merge process of the Pull request. label Jul 15, 2024
@mergify mergify bot merged commit bd552e3 into main Jul 15, 2024
12 checks passed
@mergify mergify bot deleted the nitin/ushow branch July 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode characters are escaped in pretty-printed Text values
2 participants