Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 'unGrid' accessor #1982

Merged
merged 2 commits into from
Jun 25, 2024
Merged

remove 'unGrid' accessor #1982

merged 2 commits into from
Jun 25, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jun 24, 2024

Towards #1981

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Jun 24, 2024
@kostmo kostmo changed the title remove grid accessor remove 'unGrid' grid accessor Jun 24, 2024
@kostmo kostmo changed the title remove 'unGrid' grid accessor remove 'unGrid' accessor Jun 24, 2024
@kostmo kostmo requested a review from byorgey June 25, 2024 14:47
@kostmo kostmo marked this pull request as ready for review June 25, 2024 14:47
byorgey
byorgey approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I guess I hadn't taken a good look at some of the new functions in src/swarm-topography/Swarm/Game/Scenario/Topography/Area.hs. It occurs to me that we could replace several of them with relatively simple uses of things from lens (e.g. allMembers, mapRows, mapIndexedMembers). I don't know if that's something you'd be interested in. If so I could make a PR.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jun 25, 2024
@mergify mergify bot merged commit 6801cdd into main Jun 25, 2024
12 checks passed
@mergify mergify bot deleted the refactor/grid-accessor branch June 25, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey