Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete stack.yaml #1963

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Delete stack.yaml #1963

merged 3 commits into from
Jun 19, 2024

Conversation

noahyor
Copy link
Member

@noahyor noahyor commented Jun 19, 2024

Delete stack.yaml

Closes #1960.

@noahyor noahyor requested a review from byorgey June 19, 2024 13:42
@xsebek
Copy link
Member

xsebek commented Jun 19, 2024

@noahyor why not get rid of the HIE stack file and make the cabal one default?

@byorgey
Copy link
Member

byorgey commented Jun 19, 2024 •
edited
Loading

@noahyor why not get rid of the HIE stack file and make the cabal one default?

Perhaps we should do that too. But aside from HLS configuration, if we are going to have a stack.yaml file in the repository we should make sure it is kept up to date. I was the one who always used to do that because I would use stack to build Swarm, but I don't any more.

@noahyor
Copy link
Member Author

noahyor commented Jun 19, 2024

Done.

@noahyor noahyor added the merge me Trigger the merge process of the Pull request. label Jun 19, 2024
@noahyor
Copy link
Member Author

noahyor commented Jun 19, 2024

We should also change the mergify rules accordingly.

@mergify mergify bot merged commit 53fe43d into main Jun 19, 2024
8 checks passed
@mergify mergify bot deleted the bugfix/remove-stack.yaml branch June 19, 2024 17:51
@nitinprakash96
Copy link
Collaborator

Since hie.yaml now defaults to cabal cradle, should it be committed to repository? If not, then I think we should still keep hie.yaml in .gitignore.

@byorgey
Copy link
Member

byorgey commented Jun 22, 2024

You're right, let's remove hie.yaml and add it to .gitignore.

@byorgey byorgey mentioned this pull request Jun 22, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete stack.yaml
4 participants
@noahyor @xsebek @byorgey @nitinprakash96