Get rid of memoizing delay + switch to a strict store #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
changed the title
byorgey
force-pushed
the
refactor/strict-store
branch
from
1a7daeb
to
df86dd4
Compare
byorgey
force-pushed
the
refactor/suspend
branch
from
4b9307e
to
1b3443b
Compare
byorgey
force-pushed
the
refactor/strict-store
branch
3 times, most recently
from
7502e70
to
ca3dcf9
Compare
byorgey
force-pushed
the
refactor/suspend
branch
from
fc23cde
to
a8e263a
Compare
byorgey
force-pushed
the
refactor/strict-store
branch
from
ca3dcf9
to
953942a
Compare
byorgey
force-pushed
the
refactor/strict-store
branch
from
953942a
to
5a86484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1948; see that issue for a much more in-depth discussion.
Depends on merging #1928 first.
A lot of this PR consists in deleting code that is either (1) ugly or (2) overly clever! 🥳
The short version is that the
Storeused to incorporate some laziness + memoization: when a cell was first allocated, it was an unevaluated thunk; it then got evaluated the first time it was referenced. However, this wasn't really needed to handle recursive definitions (which is the only thing we were using it for). Getting rid of it means we can get rid of a lot of weird ugly code needed to wrap free variables in extra calls toforceand so on.The new and improved
Storejust storesValues, period. A specialVBlackholevalue was added, to be used while evaluating a recursivelet.Note that
VRefis no longer really used, but I left it there for use in implementing #1660 . Once we have mutable references we can use them + delay/force to implement lazy cells.