Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonempty grid rows #1933

Merged
merged 4 commits into from
Jul 1, 2024
Merged

nonempty grid rows #1933

merged 4 commits into from
Jul 1, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jun 15, 2024 •
edited
Loading

Closes #1843

Towards #1981

@restyled-io restyled-io bot mentioned this pull request Jun 15, 2024
Closed
@kostmo kostmo force-pushed the refactor/nonempty-grid-rows branch 3 times, most recently from 63f428c to 2cc025e Compare June 27, 2024 00:40
@restyled-io restyled-io bot mentioned this pull request Jun 27, 2024
Closed
@kostmo kostmo force-pushed the refactor/nonempty-grid-rows branch 4 times, most recently from eb9ec3e to 80b2351 Compare June 29, 2024 02:15
@kostmo kostmo changed the title [WIP] nonempty grid rows nonempty grid rows Jun 29, 2024
@kostmo kostmo requested a review from byorgey June 29, 2024 02:36
@kostmo kostmo marked this pull request as ready for review June 29, 2024 02:36
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Jun 29, 2024
@kostmo kostmo force-pushed the refactor/nonempty-grid-rows branch 2 times, most recently from 46fffbc to b897692 Compare June 30, 2024 20:01
@kostmo kostmo force-pushed the refactor/nonempty-grid-rows branch from b897692 to 52c4a7c Compare July 1, 2024 01:44
@kostmo kostmo force-pushed the refactor/nonempty-grid-rows branch from 52c4a7c to 6051237 Compare July 1, 2024 01:44
@kostmo kostmo mentioned this pull request Jul 1, 2024
Open
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jul 1, 2024
@mergify mergify bot merged commit 9a5fe48 into main Jul 1, 2024
12 checks passed
@mergify mergify bot deleted the refactor/nonempty-grid-rows branch July 1, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use NonEmpty and separate EmptyGrid constructor for Grid
2 participants
@kostmo @byorgey