Grant RobotIntoWater achievement
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
added
the
CHANGELOG
|
Heads up on the build error: #1505 |
kostmo
reviewed
Sep 10, 2023
There was a problem hiding this comment.
It would be great to have an integration test for this (see #1507), but in lieu of such a framework, can you add a "test plan" to the toplevel PR description?
There was a problem hiding this comment.
@kostmo good idea. How's this?
There was a problem hiding this comment.
Following a suggestion from @xsebek I added an actual integration test.
4 tasks
|
If the achievements are part of GameState, then you can test it in
|
|
Good idea, done! |
Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1435. Some refactoring, + grant
RobotIntoWaterachievement when a robot dies in the water.