Use NonEmpty to eliminate some partial functions #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byorgey
approved these changes
Sep 9, 2023
src/Swarm/TUI/View/Attribute/Attr.hs
Outdated
| @@ -108,41 +108,41 @@ swarmAttrMap = | |||
| ] | |||
|
|
|||
| entityAttr :: AttrName | |||
| entityAttr = fst $ head worldAttributes | |||
| entityAttr = NE.head worldAttributeNames | |||
There was a problem hiding this comment.
While we're at it, can we move the definition of entityAttr here and then have the definition of worldAttributeNames depend on this instead of vice versa? As it stands, someone might edit the definition of worldAttributeNames without realizing it would affect entityAttr.
kostmo
force-pushed
the
refactor/total-functions-with-nonempty
branch
from
dc2144d
to
d8bd579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.