Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'use' command #1287

Merged
merged 1 commit into from
May 30, 2023
Merged

'use' command #1287

merged 1 commit into from
May 30, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented May 29, 2023 •
edited
Loading

Towards #1007

The use command adopts the same return type as drill:

use : text -> dir -> cmd (unit + text)

Demo

scripts/play.sh --scenario data/scenarios/Testing/1007-use-command.yaml --autoplay

@kostmo kostmo marked this pull request as ready for review May 29, 2023 18:00
@kostmo kostmo requested a review from byorgey May 29, 2023 18:00
@xsebek
Copy link
Member

xsebek commented May 30, 2023

Thanks for taking this up @kostmo! 👍

Out of curiosity, is removing drill the only missing thing to close the Issue?

xsebek

This comment was marked as duplicate.

Sign in to view

xsebek
xsebek approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I have not touched Haskell in weeks so any code would look beautiful. 🤩

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label May 30, 2023
@mergify mergify bot merged commit 4bcf1b9 into main May 30, 2023
@mergify mergify bot deleted the feature/use branch May 30, 2023 17:47
@kostmo
Copy link
Member Author

kostmo commented May 30, 2023

is removing drill the only missing thing to close the Issue?

I think that removing drill can be a separate issue (if we decide to do so at all), so I've closed it. Note there is also a separate issue #1238 to implement something even more drill-like.

@kostmo kostmo mentioned this pull request May 30, 2023
Draft
byorgey
byorgey reviewed May 30, 2023
View reviewed changes
data/scenarios/Testing/1007-use-command.yaml Show resolved Hide resolved
src/Swarm/Game/Step.hs Show resolved Hide resolved
src/Swarm/Language/Capability.hs Show resolved Hide resolved
This was referenced Jun 3, 2023
Merged
Open
mergify bot pushed a commit that referenced this pull request Jun 4, 2023
@kostmo
Cleanup 'use' command code (#1299)
bdea72f 
From review feedback in #1287
@byorgey byorgey mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey left review comments

@xsebek xsebek xsebek approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostmo @xsebek @byorgey