Fix SidePanel's main content size during async onClose callback (#2516)

sumup-oss · May 21, 2024 · d3ce6bf · d3ce6bf
1 parent 01e1544
commit d3ce6bf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/eighty-dogs-shop.md b/.changeset/eighty-dogs-shop.md
@@ -0,0 +1,5 @@
+---
+'@sumup/circuit-ui': patch
+---
+
+Fixed the size of the main content while the SidePanel's `onClose` callback is pending.
diff --git a/packages/circuit-ui/components/SidePanel/SidePanelContext.tsx b/packages/circuit-ui/components/SidePanel/SidePanelContext.tsx
@@ -143,10 +143,6 @@ export function SidePanelProvider({
 
       const sidePanelIndex = sidePanelsRef.current.indexOf(panel);
 
-      if (!isInstantClose) {
-        setIsPrimaryContentResized(sidePanelIndex !== 0);
-      }
-
       // Remove the side panel and all panels above it in reverse order
       const sidePanelsToRemove = sidePanelsRef.current
         .slice(sidePanelIndex)
@@ -163,6 +159,10 @@ export function SidePanelProvider({
             await promisify(sidePanel.onClose);
           }
 
+          if (!isInstantClose) {
+            setIsPrimaryContentResized(sidePanelIndex !== 0);
+          }
+
           await new Promise<void>((resolve) => {
             const lastPanel = index === sidePanelsToRemove.length - 1;