[Draft] Validate responses #1450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-collier
force-pushed
the
validate_responses
branch
from
37ed57d
to
5364d02
Compare
aaron-collier
force-pushed
the
validate_responses
branch
from
5364d02
to
7dcb6c0
Compare
|
Code Climate has analyzed commit 814c655 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 97.9% (-0.1% change). View more on Code Climate. |
|
Closing this PR as it is blocked by: interagent/committee#257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
fixes #1407
Adds response schemas for validation.
Marking this as draft until pairing review with @ndushay and @jmartin-sul
Was the usage documentation (e.g. wiki, README, queue or DB specific README) updated?
N/A
Does this change affect how this application integrates with other services?
If so, please confirm change was tested on stage and/or test added to sul-dlss/infrastructure-integration-test.