feat: create an exportable version of plan loading #91
Conversation
|
Since this depends on the #89 I'm switching this PR temporarily into draft mode. |
|
This should be ready to go now. |
| if(NOT BUILD_SUBDIR_NAME EQUAL "release") | ||
| message( | ||
| SEND_ERROR, | ||
| "The planloader library does not work in Debug mode due to its dependencies." |
There was a problem hiding this comment.
Why not? Does this mean you can't build the planloader in debug mode (annoying but ok)? Or does this mean that someone linking to the planloader cannot build in debug (probably an issue)?
There was a problem hiding this comment.
The problem is all of the sanitization stuff that we're including in debug mode. An unfettered debug mode would be fine.
| extern "C" { | ||
|
|
||
| using SerializedPlan = struct { | ||
| // If set, contains a serialized ::substrait::proto::Plan object. |
There was a problem hiding this comment.
I've become used to // indicating "internal comment" and /// indicating "formal documentation". Do we want to stick to that convention?
There was a problem hiding this comment.
I'm not sure I want to formalize this interface. If someone wants to use the C++ code they should be using the recently exposed substrait_io library. This version is for wrapping purposes only so I'd like it to be more obscure.
This PR adds an installable target of the plan loading routines (notably the text format) that is more readily consumed by other languages.