Add OVN IC CI #1338
Merged
Add OVN IC CI #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfarrell07
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1338/dfarrell07/ovn_ic_ci_pr |
aswinsuryan
approved these changes
Aug 15, 2023
|
@mkolesnik can you please review? |
mkolesnik
requested changes
Aug 15, 2023
dfarrell07
force-pushed
the
ovn_ic_ci_pr
branch
2 times, most recently
from
685ec28
to
42ce623
Compare
Fixes: submariner-io/enhancements#209 Co-authored-by: Mike Kolesnik <[email protected]> Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07
force-pushed
the
ovn_ic_ci_pr
branch
from
42ce623
to
c4fbe0d
Compare
mkolesnik
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
LGTM, but based on #1297 (comment) perhaps you want to always rebuild OVN images, at least until they fix it..
It doesn't have to be part of this patch but since you're already changing this area might as well..
If not, then it should probably be done either way after this gets merged.
|
Let's do it after we rebase the kind 0.20 bump on to this and test both the rebuilt image and the old image. |
|
🤖 Closed branches: [z_pr1338/dfarrell07/ovn_ic_ci_pr] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: submariner-io/enhancements#209