Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local Shipyard when testing consuming E2E #1114

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Use local Shipyard when testing consuming E2E #1114

merged 1 commit into from
Sep 14, 2023

Conversation

mkolesnik
Copy link
Collaborator

Consuming projects running E2E tests rely on code supplied by Shipyard. Use the local Shipyard when testing them, to make sure the latest code is tested, and catch any breakages.

Resolves #756

Depends on #1112

Signed-off-by: Mike Kolesnik [email protected]

@submariner-bot
Copy link

🤖 Created branch: z_pr1114/mkolesnik/consuming-with-local

@mkolesnik mkolesnik added the e2e-projects Run E2E tests in each consuming project label Jan 23, 2023
@submariner-bot submariner-bot mentioned this pull request Jan 30, 2023
Merged
@submariner-bot
Copy link

🤖 The base of this PR has been updated to devel
Please rebase this branch and remove #1114 related commits

@submariner-bot submariner-bot changed the base branch from z_pr1112/mkolesnik/local-replace to devel January 30, 2023 12:44
@github-actions
Copy link

This PR/issue depends on:

@nyechiel
Copy link
Member

@mkolesnik can you take another look at this one please?

@stale
Copy link

stale bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 2, 2023
@nyechiel
Copy link
Member

nyechiel commented Apr 2, 2023

@mkolesnik ping?

@stale stale bot removed the wontfix This will not be worked on label Apr 2, 2023
@nyechiel
Copy link
Member

nyechiel commented May 4, 2023

@mkolesnik ping

@stale
Copy link

stale bot commented May 21, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 21, 2023
@mkolesnik mkolesnik removed the wontfix This will not be worked on label May 23, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 10, 2023
@mkolesnik mkolesnik removed the wontfix This will not be worked on label Jun 13, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 12, 2023
@nyechiel
Copy link
Member

@mkolesnik can you take a look?

@mkolesnik mkolesnik removed the wontfix This will not be worked on label Sep 5, 2023
@mkolesnik mkolesnik requested a review from skitt September 6, 2023 14:31
skitt
skitt approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the other projects and the removal of the working-directory parameter on the shared e2e action won’t break anything.

@mkolesnik
Use local Shipyard when testing consuming E2E
802df1d 
Consuming projects running E2E tests rely on code supplied by Shipyard.
Use the local Shipyard when testing them, to make sure the latest code
is tested, and catch any breakages.

Shipyard has to be checked out as a sub directory for it to be
available inside the ephemeral container that we use to run the tests.
That way we can easily use `go replace` to test the updated code.

Signed-off-by: Mike Kolesnik <[email protected]>
@mkolesnik
Copy link
Collaborator Author

Resolved the conflict (checkout version was bumped)

@mkolesnik mkolesnik enabled auto-merge (rebase) September 14, 2023 12:21
@mkolesnik mkolesnik merged commit 37a96ab into submariner-io:devel Sep 14, 2023
55 checks passed
@submariner-bot
Copy link

🤖 Closed branches: [z_pr1114/mkolesnik/consuming-with-local]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@tpantelis tpantelis tpantelis approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
automation e2e-projects Run E2E tests in each consuming project
Projects
No open projects
Submariner 0.16
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consuming project check should check updated library as well
5 participants
@mkolesnik @submariner-bot @nyechiel @skitt @tpantelis