Prevent saving a broken METS file (kitodo#5883)

Throw an illegal argument exception if either side of the pair is null
subhh · Feb 21, 2024 · 5764cac · 5764cac
1 parent 0e0dcf8
commit 5764cac
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/Kitodo-DataFormat/src/main/java/org/kitodo/dataformat/access/MetsXmlElementAccess.java b/Kitodo-DataFormat/src/main/java/org/kitodo/dataformat/access/MetsXmlElementAccess.java
@@ -428,6 +428,12 @@ private DivType generatePhysicalStructMapRecursive(PhysicalDivision physicalDivi
     private StructLink createStructLink(LinkedList<Pair<String, String>> smLinkData) {
         StructLink structLink = new StructLink();
         structLink.getSmLinkOrSmLinkGrp().addAll(smLinkData.parallelStream().map(entry -> {
+            if (Objects.isNull(entry.getLeft())) {
+                throw new IllegalArgumentException("smLinkData.entry[?].left must not be null");
+            }
+            if (Objects.isNull(entry.getRight())) {
+                throw new IllegalArgumentException("smLinkData.entry[?].right must not be null");
+            }
             SmLink smLink = new SmLink();
             smLink.setFrom(entry.getLeft());
             smLink.setTo(entry.getRight());