Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide content length for the put method #78

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

murasakiakari
Copy link

@murasakiakari murasakiakari commented Oct 29, 2023

Since there is some webdav server implementation (such as nextcloud) give unexpected behavior when there is no content length is set in the put request. Therefore, I introduce the contentLength parameter to the *Client.put() method to provide the correct content length of the body to the server to prevent the behavior mention above.

@murasakiakari murasakiakari marked this pull request as ready for review October 29, 2023 14:31
@chripo
Copy link
Member

chripo commented Oct 29, 2023

Thanks!
Could you add / update our tests?

@murasakiakari
Copy link
Author

murasakiakari commented Oct 29, 2023

Thanks for your message.
I has some idea on how to make a unit after taking a rest, I will update the unit test asap.

@murasakiakari
Copy link
Author

Unit test is added, thank you for your reminding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants