Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] URL query keys percent encoding #68

Merged
merged 1 commit into from
Apr 10, 2024

[fix] add percent encoding also for keys in url queries

d329c5f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[fix] URL query keys percent encoding #68

[fix] add percent encoding also for keys in url queries
d329c5f
Select commit
Loading
Failed to load commit list.
GitHub Actions / macOS 13, Xcode 15.2 Test Results succeeded Apr 10, 2024 in 0s

Xcode test results

Testing workspace Networking with scheme Networking

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
38380006.49s

Test Summary

NetworkingTests

  • Device: Apple Virtual Machine 1, 14.4.1 (23E224)
  • SDK: macOS 14.2, 14.2
TestTotalSuccessFailureSkippedExpected Failure
test-class ErrorProcessorTests66000
test-class EndpointRequestStorageProcessorTests66000
test-class EndpointIdentifiableTests11000
test-class StoredResponseProviderTests33000
test-class AuthorizationTokenInterceptorTests77000
test-class MultipartFormDataEncoderTests44000
test-class AssociatedArrayQueryTests11000
test-class StatusCodeProcessorTests44000
test-class URLParametersTests66000

Failure Failures

All tests passed 🎉

Code Coverage

Coverage Covered Executable
Networking 42.57 % 885 2079
  ResponseProcessing.swift 100.00 % 8 8
  UploadAPIManager.swift 0.00 % 0 286
  AuthorizationTokenInterceptor.swift 72.94 % 62 85
  FileDataWriter.swift 25.00 % 1 4
  AuthorizationError.swift 0.00 % 0 12
  EndpointRequestStorageProcessor.swift 77.65 % 198 255
  URLQueryItem+PercentEncoding.swift 87.50 % 7 8
  URLSessionTask+DownloadState.swift 0.00 % 0 17
  ErrorProcessing.swift 100.00 % 8 8
  RequestAdapting.swift 62.50 % 5 8
  BasicDownloadRouter.swift 0.00 % 0 9
  ThreadSafeDictionary.swift 0.00 % 0 16
  BasicUploadRouter.swift 0.00 % 0 19
  Retryable.swift 96.15 % 25 26
  CustomEncodedParameter.swift 100.00 % 3 3
  Requestable+Convenience.swift 90.15 % 119 132
  URLSessionTask+AsyncResponse.swift 0.00 % 0 75
  StoredResponseProvider.swift 97.78 % 44 45
  EndpointIdentifiable.swift 94.83 % 55 58
  DownloadAPIManaging.swift 0.00 % 0 14
  String+PlusSignEncoded.swift 100.00 % 5 5
  ArrayParameter.swift 100.00 % 4 4
  AuthorizationManaging.swift 100.00 % 26 26
  Counter.swift 100.00 % 12 12
  AuthorizationData.swift 85.71 % 12 14
  UploadAPIManaging.swift 0.00 % 0 7
  HTTPStatusCode.swift 75.00 % 9 12
  URL+Convenience.swift 0.00 % 0 13
  DownloadAPIManager.swift 0.00 % 0 297
  MultipartFormData.swift 41.38 % 24 58
  EndpointRequest.swift 100.00 % 5 5
  MultipeerConnectivityManager.swift 0.00 % 0 78
  APIManaging.swift 18.75 % 3 16
  UploadTask+State.swift 0.00 % 0 27
  StatusCodeProcessor.swift 100.00 % 19 19
  LoggingInterceptor.swift 0.00 % 0 86
  NetworkError.swift 0.00 % 0 14
  MultipartFormDataEncoder.swift 95.42 % 125 131
  RetryConfiguration.swift 95.00 % 19 20
  ResponseProviding.swift 100.00 % 3 3
  EndpointRequestStorageModel.swift 92.86 % 13 14
  MultipartFormData+BodyPart.swift 100.00 % 17 17
  Sequence+Convenience.swift 100.00 % 7 7
  APIManager.swift 73.44 % 47 64
  UploadTask.swift 0.00 % 0 42
Total 42.57 % 885 2079

Details

Test Details

NetworkingTestsback

ErrorProcessorTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)6.26s
Successtest-method test_errorProcessing_process_mappingUnacceptableToUnrelatedThroughSimpleShouldSucceed()
Successtest-method test_errorProcessing_process_noProcessorsShouldReturnOriginalError()
Successtest-method test_errorProcessing_process_mappingUnacceptableToSimpleErrorShouldSucceed()
Successtest-method test_apiManager_request_errorShouldBeMappedToSimpleError()
Successtest-method test_errorProcessing_process_undefinedCaseShouldReturnOriginalError()
Successtest-method test_apiManager_request_originalErrorShouldRemain()

EndpointRequestStorageProcessorTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.22s
Successtest-method testResponseStaysTheSameAfterStoringData()
Successtest-method testProcessCreatesCorrectFolder()
Successtest-method testStoredDataForGetRequestWithImageResponse()
Successtest-method testStoredDataForPostRequest()
Successtest-method testStoredDataForGetRequestWithJSONResponse()
Successtest-method testStoredDataForGetRequestWithErrorResponse()

EndpointIdentifiableTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testEqualIdentifiers()

StoredResponseProviderTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testUnableToLoadAssetError()
Successtest-method testUnableToConstructResponseError()
Successtest-method testLoadingData()

AuthorizationTokenInterceptorTests back

SuccessFailureSkippedExpected Failure⏱️
7 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testFailedRequestAuthorization()
Successtest-method testFailedTokenRefresh()
Successtest-method testAuthenticationNotRequiredRequest()
Successtest-method testFailedRefreshWithMultipleParallelRequests()
Successtest-method testSuccessfulRequestAuthorization()
Successtest-method testSuccessfulRefreshWithMultipleParallelRequests()
Successtest-method testSuccessfulTokenRefresh()

MultipartFormDataEncoderTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method test_encode_throwsFileAlreadyExists()
Successtest-method test_encode_encodesDataAsExpected()
Successtest-method test_encode_throwsInvalidFileUrl()
Successtest-method test_encode_encodesToFileAsExpected()

AssociatedArrayQueryTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testMultipleKeyParamaterURLCreation()

StatusCodeProcessorTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testUnacceptableStatus1()
Successtest-method testNotHttpsURLResponse()
Successtest-method testUnacceptableStatus2()
Successtest-method testEmptyAcceptableStatuses()

URLParametersTests back

SuccessFailureSkippedExpected Failure⏱️
6 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testPlusSignPercentEncodedParameter()
Successtest-method testPlusSignDefaultEncoding()
Successtest-method testMixedPlusSignPercentEncodedParameter()
Successtest-method testMixedPercentEncodedParameter()
Successtest-method testDefaultEncoding()
Successtest-method testCustomPercentEncodedParameter()
View more details on GitHub Actions