Merge pull request #69 from strvcom/feat/sorted-query-parameters

Sorted url query parameters for better caching support
strvcom · May 9, 2024 · 5d7df2e · 5d7df2e
2 parents de68c75 + 137bf0e
commit 5d7df2e
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Sources/Networking/Core/Requestable+Convenience.swift b/Sources/Networking/Core/Requestable+Convenience.swift
@@ -109,9 +109,12 @@ public extension Requestable {
 // MARK: Build Query Items
 private extension Requestable {
     func buildPercentEncodedQueryItems(urlParameters: [String: Any]) -> [URLQueryItem] {
-        urlParameters
-            .map { key, value -> [URLQueryItem] in
-                buildPercentEncodedQueryItem(key: key, value: value)
+        urlParameters.keys.sorted()
+            .map { key -> [URLQueryItem] in
+                guard let value = urlParameters[key] else {
+                    return []
+                }
+                return buildPercentEncodedQueryItem(key: key, value: value)
             }
             .flatMap { $0 }
     }