Use consistent formatting using clang-format #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support running `make format` to format files locally. - Check format in pre-commit hook. - Check format on Travis.
fancycode
force-pushed
the
clang-format
branch
from
195dda7
to
3fd06f6
Compare
|
Sorry, I'm no proponent of automatic formatting. Just have a look how it destroys all the tables I added in the heif.h comments and intentional paragraphs. I like to have variable number of empty lines to indicate code section, ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get a consistent code format, I suggest using clang-format to format files.
This PR contains a configuration file with formatting definitions (see http://releases.llvm.org/3.9.0/tools/clang/docs/ClangFormatStyleOptions.html for further details) and integrates
clang-formatin the Makefile, pre-commit hook and Travis tests.The actual formatting is in a separate commit to make reviewing / cherry-picking the changes easier.
Please let me know what you think, imho a consistent code style helps a lot with readability.
NOTE: You can even integrate it with emacs: https://clang.llvm.org/docs/ClangFormat.html#emacs-integration 😃