Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding maxBytesPerTrigger tag for Pulsar Admission Control #151
Adding maxBytesPerTrigger tag for Pulsar Admission Control #151
Changes from all commits
66667d4
9d5ceef
10b9444
63ac0a9
eb73093
6b858d7
4347744
b491844
423efe4
769890e
dbadb7e
54ea233
843f7c9
8f51130
0cf4dd7
fb645ec
f4a3b39
be7d93c
9a4b1a4
b0a4450
dbe6528
b6a114c
2e69b5f
4d00f88
9369424
3103b66
4712cf4
a3acee5
bf3dfe6
12deb6b
b922024
eeb0b45
c115f6f
8c4a7e2
6e7b93c
c69d34b
305fb2c
3fdc0b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a bug that pulsar consumer do not attempt to reconnect when doing seek(), can you leave a comment here explaining why this change is needed and TODO that we will get rid of this once we upgraded to a version that has the fix?