Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set operations instead of side-effects #202

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Use set operations instead of side-effects #202

merged 3 commits into from
Jul 18, 2023

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jul 18, 2023 •
edited
Loading

Related #198

@mulkieran mulkieran self-assigned this Jul 18, 2023
@mulkieran
Use set operations instead of side-effects
63af50a 
It's less confusing not to mutate the data structures being processed.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran marked this pull request as ready for review July 18, 2023 19:48
@mulkieran mulkieran merged commit 06f3fbd into stratis-storage:master Jul 18, 2023
3 checks passed
@mulkieran mulkieran deleted the set-operations branch July 18, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgurney-rh bgurney-rh bgurney-rh approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mulkieran @bgurney-rh