Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate plugins that work for v5 #16

Merged
merged 9 commits into from
May 20, 2024
Merged

Conversation

innerdvations
Copy link
Collaborator

@innerdvations innerdvations commented May 20, 2024

What does it do?

  • updates strapi/pack-up to use version with log + build async fixes
  • updates commander (not strictly necessary here but it works)
  • use export * as X from 'X' syntax instead of import X from 'X'; export default { X } to correctly preserve inferred types

Why is it needed?

Plugins were still broken for v5

How to test it?

There is one missing piece to get it to build, which is the tsconfig: strapi/strapi#20341

But if you generate a plugin and then manually add that to the tsconfig yourself, it should now build with no errors.

Related issue(s)/PR(s)

strapi/strapi#20341

DX-1400

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: ea7059a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/cli/commands/plugin/init/action.ts Outdated Show resolved Hide resolved
src/cli/commands/plugin/init/action.ts Outdated Show resolved Hide resolved
@innerdvations innerdvations merged commit 80d6ab4 into main May 20, 2024
1 check passed
@innerdvations innerdvations deleted the fix/build-error branch May 20, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants