Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit max upload size #224

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix: limit max upload size #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54aa36e
fix: limit max upload size
vasco-santos Sep 11, 2023
50fa05e
chore: update upload-api to check limit right in the start
vasco-santos Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion upload-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@web-std/fetch": "^4.1.0",
"@web3-storage/access": "^14.0.0",
"@web3-storage/capabilities": "^9.0.0",
"@web3-storage/upload-api": "^5.3.0",
"@web3-storage/upload-api": "^5.3.1",
"@web3-storage/w3infra-ucan-invocation": "*",
"multiformats": "^11.0.1",
"nanoid": "^4.0.2",
Expand Down
8 changes: 6 additions & 2 deletions upload-api/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ Sentry.AWSLambda.init({

export const createServiceRouter = UploadAPI.createService

export const MAX_S3_PUT_SIZE = 5_000_000_000
// S3 Put command has hard-limit of 5GiB.
// By limiting CAR size to 127*(1<<25), we guarantee max-4GiB-padded Filecoin pieces
// and have better utilization of Fil sector space.
// By receiving one more byte, we would immediatly get to 8GiB padded piece.
export const MAX_UPLOAD_SIZE = 127*(1<<25)

/**
* @param {import('@ucanto/interface').Signer} servicePrincipal
Expand All @@ -19,7 +23,7 @@ export const createUcantoServer = (servicePrincipal, context) =>
UploadAPI.createServer({
...context,
id: servicePrincipal,
maxUploadSize: MAX_S3_PUT_SIZE,
maxUploadSize: MAX_UPLOAD_SIZE,
errorReporter: {
catch: (/** @type {string | Error} */ err) => {
console.warn(err)
Expand Down