Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: index upload table by root CID #218

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

travis
Copy link
Member

@travis travis commented Aug 14, 2023

@dchoi27 needs to be able to figure out which space an upload went to, ie, he needs to be able to search space DIDs by upload CID

I'm not sure that we need insertedAt in here, but I do think it will be helpful to be able to see when a CID was uploaded to various spaces in the admin UI, so I'm including it in the projection. It would not be hard to convince me that we should leave it out...

@dchoi27 needs to be able to figure out which space an upload went to, ie, he needs to be able to search space DIDs by upload CID

I'm not sure that we need `insertedAt` in here, but I do think it will be helpful to be able to see when a CID was uploaded to various spaces in the admin UI, so I'm including it in the projection. It would not be hard to convince me that we should leave it out...
@seed-deploy seed-deploy bot temporarily deployed to pr218 August 14, 2023 22:47 Inactive
@seed-deploy
Copy link

seed-deploy bot commented Aug 14, 2023

View stack outputs

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having insertedAt gives us some potentially useful info. Go for it.

@travis travis merged commit e742d65 into main Aug 15, 2023
1 check passed
@travis travis deleted the feat/index-uploads-by-cid branch August 15, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants