Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin @stoplight/json dep to 3.20.0 #2567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yjp20
Copy link

@yjp20 yjp20 commented Jul 19, 2024

Addresses #2566

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@yjp20 yjp20 requested a review from a team as a code owner July 19, 2024 21:35
@rattrayalex
Copy link

cc @chohmann – any chance you could give this a quick stamp? the bad dep causes things to be Very Broken.

@RobertCraigie
Copy link

cc @mnaumanali94 can anyone take a look at this? it's breaking everything for us

@mnaumanali94 mnaumanali94 self-requested a review July 22, 2024 21:48
@mnaumanali94
Copy link
Contributor

@RobertCraigie The team should be able to look at this tomorrow. We're in a bit of a transition in terms of ownership - we apologize for the wait.

@rattrayalex
Copy link

@mnaumanali94 anything we could do to persuade you to go ahead and release this? It's just a dependency pin to a previous-known-good version, and the breakage is quite bad (for us at least, and it seems, others too).

@mnaumanali94
Copy link
Contributor

@rattrayalex This issue should be fixed now as a new version of stoplight/json should fix the error. Can y'all confirm please?

@rattrayalex
Copy link

Amazing, thank you @mnaumanali94 ! We'll give it a try shortly!

@RobertCraigie
Copy link

It looks like it's still failing but I haven't verified if this CI run is using the new stoplight/json version or not.

We've published a fork of prism-cli with the fix in this PR which is passing all our tests.

@mnaumanali94
Copy link
Contributor

Is there a reason you are reverting to 3.20.0 and not 3.21.0?

@mnaumanali94
Copy link
Contributor

Also trying on the command line with the steps to reproduce It doesn't fail. Can you see if the CI is using the right version?

@RobertCraigie
Copy link

@mnaumanali94 see this CI run which includes a debug log showing the versions of all deps.

It's using @stoplight/[email protected] and failing.

@lukaszm-sb lukaszm-sb added the dependencies Pull requests that update a dependency file label Aug 23, 2024
@Didel
Copy link

Didel commented Sep 12, 2024

Resolves #2578

Copy link
Contributor

@lukaszzazulak lukaszzazulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yjp20 sorry for the delay, could you resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants