Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.redhat.com/browse/ACM-14988 #7210

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

dockerymick
Copy link
Contributor

No description provided.

Copy link
Contributor

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
E1017 12:55:24.532493 1 dashboard_controller.go:147] dashboard: sample-dashboard could not be created after retrying 40 times
----

. To fix the dashboard failure, redeploy Grafana by scaling the number of replicas to `0`. The `multicluster-observability-operator` pod automatically scales the number of replicas after you change it to `0`. Run the following command:
Copy link
Contributor

@jacobbaungard jacobbaungard Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest edit, makes this a bit more unclear. Just explain in detail a little more what happens when you execute that command is:

  1. Kubernetes scales down the number of replicas to 0 as requested in the command
  2. The multicluster-observability-operator pod sees that the number of replicas are 0, which doesn't match the configured number of replicas, and therefore it scales the number of replicas back up to whatever number is configured in in the multicluster-observability config (2 by default).
Suggested change
. To fix the dashboard failure, redeploy Grafana by scaling the number of replicas to `0`. The `multicluster-observability-operator` pod automatically scales the number of replicas after you change it to `0`. Run the following command:
. To fix the dashboard failure, redeploy Grafana by scaling the number of replicas to `0`. The `multicluster-observability-operator` pod will automatically scale the deployment back up to the correct number of replicas. Run the following command:

@dockerymick
Copy link
Contributor Author

@jacobbaungard thanks! I just made another update based on your comment

Copy link
Contributor

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
Copy link
Collaborator

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dockerymick, jacobbaungard, jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dockerymick
Copy link
Contributor Author

Thanks to you both for approving! @jacobbaungard @jc-berger
Merging this PR

@dockerymick dockerymick merged commit 0047d79 into 2.12_stage Nov 4, 2024
0 of 2 checks passed
@dockerymick dockerymick deleted the mj-ACM-14988-212 branch November 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants