Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://issues.redhat.com/browse/ACM-14574--new function on install disc #7196

Merged
merged 4 commits into from
Nov 4, 2024
Merged

https://issues.redhat.com/browse/ACM-14574--new function on install disc #7196

merged 4 commits into from
Nov 4, 2024

Conversation

swopebe
Copy link
Contributor

@swopebe swopebe commented Oct 29, 2024

No description provided.

@swopebe swopebe requested a review from dislbenn October 30, 2024 11:05
dislbenn
dislbenn approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@dislbenn dislbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2024
@dockerymick dockerymick self-requested a review November 4, 2024 13:59
dockerymick
dockerymick approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@dockerymick dockerymick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments. Otherwise, this looks good to me

install/install_disconnected.adoc Outdated
[#disconnect-catalog-priority]
=== Catalog source priority

When the `MulticlusterHub` resource prepares to install the {mce-short}, it implements `CatalogSource` priority as criteria.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be MultiClusterHub? When I searched through the doc, I saw both instances being used. We can create a tech debt issue to make sure we are referencing the correct resource name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I can change for this and get to the rest another time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all have been changed

install/install_disconnected.adoc Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dislbenn, dockerymick, swopebe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

New changes are detected. LGTM label has been removed.

@swopebe swopebe merged commit 44798c3 into 2.12_stage Nov 4, 2024
0 of 2 checks passed
@swopebe swopebe deleted the swope-install-cs branch November 4, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerymick dockerymick dockerymick approved these changes

@dislbenn dislbenn dislbenn approved these changes

Assignees

@dislbenn dislbenn

@dockerymick dockerymick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swopebe @dislbenn @dockerymick