Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE AFTER 2.12 PUBLISH] [2.11_stage] Add containerArguments docs to Gatekeeper #7111

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dhaiducek
Copy link
Contributor

  • Add containerArguments docs to Gatekeeper

ref: https://issues.redhat.com/browse/ACM-14700

Cherry-pick:

* Add `containerArguments` docs to Gatekeeper

ref: https://issues.redhat.com/browse/ACM-14700
Signed-off-by: Dale Haiducek <[email protected]>

* Fix build failures

Signed-off-by: Dale Haiducek <[email protected]>

* Update acm_whats_new.adoc

Adding what's new entry

---------

Signed-off-by: Dale Haiducek <[email protected]>
Co-authored-by: Mikela Jackson <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhaiducek

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaiducek
Copy link
Contributor Author

@jc-berger @dockerymick Not sure when 2.11 will be refreshed, but this PR shouldn't merge until Gatekeeper 3.17 is released. If the refresh doesn't happen until next Friday or something, then I think this can merge? Otherwise we should probably wait a bit.

@dockerymick
Copy link
Contributor

@dhaiducek will you remind us of the release date for Gatekeeper 3.17. We expect to refresh today

@dhaiducek
Copy link
Contributor Author

Okay, I'll set a reminder for myself to come back around to this. The Gatekeeper 3.17 GA is aligned with ACM 2.12, so I think next Tuesday (assuming it doesn't slip)?

@dockerymick dockerymick changed the title [2.11_stage] Add containerArguments docs to Gatekeeper [DO NOT MERGE] [2.11_stage] Add containerArguments docs to Gatekeeper Oct 18, 2024
@dockerymick
Copy link
Contributor

To help reduce the PRs for pencils down and to avoid merge conflicts, I recommend that we create an issue for this update. After the issue is created and we add this PR to it as a reference, we can close the PR and reopen another after 2.12 GA @dhaiducek

@dockerymick
Copy link
Contributor

Here is the link to the new issue: https://issues.redhat.com/browse/ACM-15321
Closing this PR

@dockerymick dockerymick closed this Nov 4, 2024
@dhaiducek
Copy link
Contributor Author

we can close the PR and reopen another after 2.12 GA @dhaiducek

Since the Gatekeeper files aren't updated much except by us, we ought to be able to re-open this PR when it's ready to be addressed (that ought to be simpler than creating another PR 🙂 )

@dockerymick dockerymick reopened this Nov 4, 2024
@dockerymick dockerymick changed the title [DO NOT MERGE] [2.11_stage] Add containerArguments docs to Gatekeeper [MERGE AFTER 2.12 PUBLISH] [2.11_stage] Add containerArguments docs to Gatekeeper Nov 7, 2024
@dhaiducek
Copy link
Contributor Author

The CI notes a broken link, but it's unrelated to this PR and where the content migrated to is also unclear, so I think this PR should be okay to merge at any time now that Gatekeeper (somewhat unexpectedly) went GA yesterday:

. Transfer the `initrd`, `kernel`, `generic.ins`, and `initrd.img.addrsize` parameter files to the file server. For more information about how to transfer the files with FTP and boot, see link:https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/performing_a_standard_rhel_8_installation/installing-in-an-lpar_installing-rhel[Installing in an LPAR].

@dockerymick
Copy link
Contributor

@dhaiducek when i copied and pasted the link it directed me here: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/#Installing%20RHEL

I think it's fine to leave as is

@dockerymick dockerymick merged commit c9f055b into stolostron:2.11_stage Nov 14, 2024
1 of 3 checks passed
Copy link
Contributor

@dockerymick dockerymick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dhaiducek dhaiducek deleted the containerargs-2.11 branch November 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants