-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MERGE AFTER 2.12 PUBLISH] [2.11_stage] Add containerArguments
docs to Gatekeeper
#7111
[MERGE AFTER 2.12 PUBLISH] [2.11_stage] Add containerArguments
docs to Gatekeeper
#7111
Conversation
* Add `containerArguments` docs to Gatekeeper ref: https://issues.redhat.com/browse/ACM-14700 Signed-off-by: Dale Haiducek <[email protected]> * Fix build failures Signed-off-by: Dale Haiducek <[email protected]> * Update acm_whats_new.adoc Adding what's new entry --------- Signed-off-by: Dale Haiducek <[email protected]> Co-authored-by: Mikela Jackson <[email protected]> Signed-off-by: Dale Haiducek <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jc-berger @dockerymick Not sure when 2.11 will be refreshed, but this PR shouldn't merge until Gatekeeper 3.17 is released. If the refresh doesn't happen until next Friday or something, then I think this can merge? Otherwise we should probably wait a bit. |
@dhaiducek will you remind us of the release date for Gatekeeper 3.17. We expect to refresh today |
Okay, I'll set a reminder for myself to come back around to this. The Gatekeeper 3.17 GA is aligned with ACM 2.12, so I think next Tuesday (assuming it doesn't slip)? |
containerArguments
docs to GatekeepercontainerArguments
docs to Gatekeeper
To help reduce the PRs for pencils down and to avoid merge conflicts, I recommend that we create an issue for this update. After the issue is created and we add this PR to it as a reference, we can close the PR and reopen another after 2.12 GA @dhaiducek |
Here is the link to the new issue: https://issues.redhat.com/browse/ACM-15321 |
Since the Gatekeeper files aren't updated much except by us, we ought to be able to re-open this PR when it's ready to be addressed (that ought to be simpler than creating another PR 🙂 ) |
containerArguments
docs to GatekeepercontainerArguments
docs to Gatekeeper
The CI notes a broken link, but it's unrelated to this PR and where the content migrated to is also unclear, so I think this PR should be okay to merge at any time now that Gatekeeper (somewhat unexpectedly) went GA yesterday:
|
@dhaiducek when i copied and pasted the link it directed me here: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/#Installing%20RHEL I think it's fine to leave as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
containerArguments
docs to Gatekeeperref: https://issues.redhat.com/browse/ACM-14700
Cherry-pick:
containerArguments
docs to Gatekeeper #7011