🐛 [backplane-2.5] Check if the token has expired (#116)

[openshift-cherrypick-robot]

This is an automated cherry-pick of #135

/assign zhujian7

Fix https://issues.redhat.com/browse/ACM-14286

[zhujian7]

@xuezhaojun

[sonarcloud]

Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

[zhujian7]

/override ci/prow/sonarcloud

[openshift-ci]

@zhujian7: Overrode contexts on behalf of zhujian7: ci/prow/sonarcloud

In response to this:

/override ci/prow/sonarcloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zhujian7]

Some less important code(some are comments) is not covered:

Uncovered code
New code
	return reconcile.Result{
		// Requeue even if the token is not refreshed, otherwise if the agent restarts
		// at the time that the token is not expried, no chance to trigger the expiration
		// check again
		RequeueAfter: checkTokenRefreshAfter(now, expiring, msa.Spec.Rotation.Validity.Duration),
	}, nil

/override "SonarCloud Code Analysis"

[openshift-ci]

@zhujian7: Overrode contexts on behalf of zhujian7: SonarCloud Code Analysis

In response to this:

Some less important code(some are comments) is not covered:

Uncovered code
New code
  return reconcile.Result{
  	// Requeue even if the token is not refreshed, otherwise if the agent restarts
  	// at the time that the token is not expried, no chance to trigger the expiration
  	// check again
  	RequeueAfter: checkTokenRefreshAfter(now, expiring, msa.Spec.Rotation.Validity.Duration),
  }, nil

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xuezhaojun]

/lgtm

I think we can just merge it manually.

[zhujian7]

/hold
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, xuezhaojun, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zhujian7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhujian7]

/unhold

[zhujian7]

/test sonarcloud

[sonarcloud]

Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

[zhujian7]

/override "ci/prow/sonarcloud"

[openshift-ci]

@zhujian7: Overrode contexts on behalf of zhujian7: ci/prow/sonarcloud

In response to this:

/override "ci/prow/sonarcloud"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.