Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ACM-15320 Remove hard coded local-cluster from App UI #4078

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Nov 15, 2024

https://issues.redhat.com/browse/ACM-15320

  • Remove hard coded local-cluster through out the code and find the hub cluster by looking for label local-cluster: true
  • Removed layouts.js - code no longer used, replaced by PatternFly topology
  • Removed DiagramViewer.js - code no longer used, replaced by PatternFly topology
  • Removed status.js - code no longer used, replaced by PatternFly topology
  • Removed application-queries.ts - code no longer used, replaced by App table performance work?

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: fxiang1 <[email protected]>
Copy link

openshift-ci bot commented Nov 15, 2024

@fxiang1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 0d4ded6 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants