Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-2589 WIP: Convert AcmDropdown to use Menu #2820

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KevinFCormier
Copy link
Contributor

@KevinFCormier KevinFCormier commented Apr 27, 2023

https://issues.redhat.com/browse/ACM-2589

  • Tests are failing - click action on menu does not seem to trigger onSelect handler
  • CSS from Applications route is causing flyout menus to not be visible

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevinFCormier KevinFCormier changed the title WIP: Convert AcmDropdown to use Menu ACM-2589 WIP: Convert AcmDropdown to use Menu Apr 27, 2023
@KevinFCormier
Copy link
Contributor Author

@dhaiducek Here's what I have so far, but I'm currently having issues with the tests.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants