-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for both embedded-hals (0.2.x and 1.0.0-alpha) #388
Conversation
b0ff319
to
c17ef0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This should probably be tested in CI, right?
cc @ryankurte Could you help with testing? |
21adc3a
to
f8e1b7e
Compare
404: Move embedded-hal implementations to subdirs r=therealprof a=burrbull Part of #388 Co-authored-by: Andrey Zgarbul <[email protected]>
a680923
to
8f4158e
Compare
feaf1e5
to
326ae3c
Compare
(newbie question - for my own sanity I really shouldn't be here.) |
This impl uses 1.0.0-alpha.6 for now. |
I understand it it is just using |
I think I am slowly starting to understand. It is not just the drivers but I actually have to go through every package, even things like |
No you don't need to change Also as I can see |
it is very much an experiment / WIP but, sorta the opposite... the idea was to pull out all the common bounds to simplify driver implementations, then provides opt-in helpers for to instantiate the radio driver you just need to call |
8342097
to
6e08b12
Compare
443: e-hal alpha.7 r=burrbull a=burrbull Same as #388, but uses alpha.7 Co-authored-by: Andrey Zgarbul <[email protected]>
CountDown
,Pwm
,Watchdogs
traits are not implemented for 1.0.0-alpha due to rust-embedded/embedded-hal#324Also need help with new spi::blocking traits.